Skip to content

Firestore: Various small improvements to the Android integration tests #1359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 30, 2023
Merged

Firestore: Various small improvements to the Android integration tests #1359

merged 4 commits into from
Jun 30, 2023

Conversation

@dconeybe
Copy link
Contributor

@dconeybe dconeybe commented Jun 23, 2023

For a description of each individual change, see the commit messages of the individual commits.

dconeybe added 3 commits June 23, 2023 16:14
@dconeybe
firestore_integration_test_android.cc: clean up some comments
7d89ff1
@dconeybe
firestore_integration_test_android_test.cc: Remove two unnecssary cal…
9546aaf 
…ls to env.ExceptionClear() since ThrowException() looks after clearing it.
@dconeybe
task_test.cc: use RefersToSameJavaObjectAs() instead of JavaEq(except…
c4fe7dc 
…ion) as it is more appropriate for what the tests are verifying.
@dconeybe dconeybe added api: firestore skip-release-notes Skip release notes check labels Jun 23, 2023
@dconeybe dconeybe self-assigned this Jun 23, 2023
@dconeybe dconeybe added the tests-requested: quick Trigger a quick set of integration tests. label Jun 23, 2023
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests-requested: quick Trigger a quick set of integration tests. labels Jun 23, 2023
@github-actions
Copy link

github-actions bot commented Jun 23, 2023 •
edited
Loading

Integration test with FLAKINESS (succeeded after retry)

Requested by @dconeybe on commit 7fad544
Last updated: Fri Jun 30 12:29 PDT 2023
View integration test log & download artifacts

Failures Configs
app_check [TEST] [FLAKINESS] [Android] [1/3 os: macos] [1/2 android_device: android_target]
(1 failed tests)  FirebaseAppCheckTest.TestDebugProviderValidToken

Add flaky tests to go/fpl-cpp-flake-tracker

@github-actions github-actions bot added the tests: succeeded This PR's integration tests succeeded. label Jun 23, 2023
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Jun 23, 2023
@dconeybe dconeybe requested a review from wu-hui June 23, 2023 23:59
@dconeybe dconeybe added tests-requested: quick Trigger a quick set of integration tests. and removed tests: succeeded This PR's integration tests succeeded. labels Jun 26, 2023
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. tests: succeeded This PR's integration tests succeeded. and removed tests-requested: quick Trigger a quick set of integration tests. labels Jun 26, 2023
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Jun 26, 2023
dconeybe added a commit that referenced this pull request Jun 26, 2023
@dconeybe
Undo changes that are covered in #1359
902f18a
@dconeybe dconeybe merged commit 7fad544 into main Jun 30, 2023
@dconeybe dconeybe deleted the dconeybe/AndroidTestRandomImprovements branch June 30, 2023 16:46
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. tests: succeeded This PR's integration tests succeeded. and removed tests: succeeded This PR's integration tests succeeded. labels Jun 30, 2023
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Jun 30, 2023
tom-andersen pushed a commit that referenced this pull request Jul 17, 2023
@dconeybe @tom-andersen
Firestore: Various small improvements to the Android integration tests (
f32a90c 
#1359)
@firebase firebase locked and limited conversation to collaborators Jul 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@wu-hui wu-hui wu-hui approved these changes

Assignees

@wu-hui wu-hui

@dconeybe dconeybe

Labels

api: firestore skip-release-notes Skip release notes check tests: succeeded This PR's integration tests succeeded.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dconeybe @wu-hui